Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clean-cargo-cache #17040

Merged
merged 1 commit into from May 29, 2017
Merged

Improve clean-cargo-cache #17040

merged 1 commit into from May 29, 2017

Conversation

UK992
Copy link
Contributor

@UK992 UK992 commented May 25, 2017

It won't delete pack files from db directory anymore, which cause #16787 and it will remove empty folders now.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 25, 2017
@asajeffrey asajeffrey requested a review from aneeshusa May 25, 2017 22:31
@asajeffrey
Copy link
Member

Not sure I'm the right person to look at this. @aneeshusa?

@jdm
Copy link
Member

jdm commented May 29, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0e072df has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey May 29, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 29, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0e072df with merge fecfd30...

bors-servo pushed a commit that referenced this pull request May 29, 2017
Improve `clean-cargo-cache`

It won't delete pack files from `db` directory anymore, which cause #16787 and it will remove empty folders now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17040)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing fecfd30 to master...

@bors-servo bors-servo merged commit 0e072df into servo:master May 29, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants